Add Calagopus#4901
Conversation
|
Resolves #4900 |
|
@stavros-k I made the changes you requested. Why did you mark this again as "requested changes", but without any further comments? |
Looks like comment was never submitted. |
|
An update implemented auto config creation in the application itself, so that logic is no longer needed. Hopefully this is enough to make this pass. |
| {% set c1 = tpl.add_container(values.consts.calagopus_container_name, "image") %} | ||
| {% do c1.add_network(calagopus_net) %} | ||
|
|
||
| {% set wings_seed_yaml -%} |
There was a problem hiding this comment.
what is this? where is it used?
There was a problem hiding this comment.
Used to be old data that would have been written to the config. This has now been removed.
There was a problem hiding this comment.
Now that we dont patch the config, how do we ensure the paths (and potentially ports etc, assuming that are declared on this file)?
There was a problem hiding this comment.
The mount path inside of the container now stays the same, and you can change the external mapping.
The port does not matter, since it only exists internally and does not get exposed.
There was a problem hiding this comment.
The mount path inside of the container now stays the same
Not really. 99% of the cases a user will mount a config file. This can contain any paths or ports. Immediately breaking the mapping.
There was a problem hiding this comment.
What do you suggest to fix this? I don't want to overengineer something, and obviously if you manually change things in a config file, it may break.
There was a problem hiding this comment.
I'll have to go over their docs first and see how all this works.
There was a problem hiding this comment.
You can find the docs at https://calagopus.com/docs/
App Addition
AI
Description
Adds Calagopus to the community train.
Calagopus is a modern, open-source game server management panel built in Rust. Deploy, monitor, and manage Minecraft, Hytale, and other game servers with industry-leading performance.
App Information
Testing
Tested locally with:
All tests passed successfully.
Icons and Screenshots
Please upload the following to the CDN:
Special Notes
Checklist